Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] NPEs in FileDetailsFragment (Play Store) #4170

Closed
wants to merge 350 commits into from
Closed

[FIX] NPEs in FileDetailsFragment (Play Store) #4170

wants to merge 350 commits into from

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Sep 25, 2023 •
edited by JuancaG05
Loading

Related Issues

App:

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

JuancaG05 and others added 30 commits September 5, 2023 09:15
@JuancaG05 @jesmrec
Added calens file
ad3a928
@JuancaG05 @jesmrec
Calens changelog updated
6b80f22
@JuancaG05 @jesmrec
Calens changelog updated
2f49cb7
@manuelplazaspalacio @jesmrec
Showing decision dialog when copying file conflict.
1e846b0
@manuelplazaspalacio @jesmrec
Showing decision dialog when moving file conflict.
bd9d48c 
Solving errors when copying, replace and keep both.
@manuelplazaspalacio @jesmrec
Refactor getting path when copying and moving files.
3f9d482
@manuelplazaspalacio @jesmrec
Solving test errors.
2a056b7
@manuelplazaspalacio @jesmrec
Adding new test to copying and moving files use cases.
f5c3795
@manuelplazaspalacio @jesmrec
Adding changelog #3935.
d82201c
@manuelplazaspalacio @jesmrec
Change name changelog to #4062.
714a3f1
@manuelplazaspalacio @jesmrec
Change library reference.
c8ae525
@manuelplazaspalacio @jesmrec
Modifying changelog.
b34476f
@manuelplazaspalacio @jesmrec
Calens changelog updated
dbe22b5
@manuelplazaspalacio @jesmrec
Cleaning MoveFileUseCase code.
f370bb4
@manuelplazaspalacio @jesmrec
Solving CR changes.
1ad4e91
@manuelplazaspalacio @jesmrec
Solving CR changes.
d62aba7
@manuelplazaspalacio @jesmrec
- Changing text on dialog when copying/moving conflict.
454e178 
- Solving bugs copying/moving conflict when doing with two or more files.
@manuelplazaspalacio @jesmrec
Calens changelog updated
cf8fd2b
@ownclouders @jesmrec
[tx] updated from transifex
7e319e7
@ownclouders @jesmrec
[tx] updated from transifex
248f80d
@ownclouders @jesmrec
[tx] updated from transifex
cfac432
@ownclouders @jesmrec
[tx] updated from transifex
87de7c5
@ownclouders @jesmrec
[tx] updated from transifex
f51321a
@JuancaG05 @jesmrec
Take into account in menu filter just files which are av. offline, no…
72cb5e6 
…t whose parents are av. offline
@JuancaG05 @jesmrec
Added calens file
d6681c3
@JuancaG05 @jesmrec
Calens changelog updated
512f1c5
@Aitorbp @jesmrec
Added margin in image item to see the imagen bigger like was before t…
91622dd 
…he re-architecture
@Aitorbp @jesmrec
Optimizing code
5ed845f
@Aitorbp @jesmrec
Added calens file
781beeb
@Aitorbp @jesmrec
Calens changelog updated
d0638c9
@JuancaG05 JuancaG05 changed the base branch from master to release/4.1.1 October 4, 2023 07:10
abelgardep and others added 23 commits October 4, 2023 08:38
@abelgardep @Aitorbp
Replace runBlocking with runTest for testing
52e86db
@Aitorbp
Changed hardcoded alue in ReleaseNotesActivityTest
f9265be
@Aitorbp
Added list mocked
cbbba28
@Aitorbp
Added new dialog to check all conflict inside
260b13a
@Aitorbp
One fix
dd31bca
@Aitorbp
Fixes from CR
a2dedec
@Aitorbp
Fixes when the screen is rotated
da3ae3a
@Aitorbp
Fix cr 2
7431cb0
@Aitorbp
Fix cr 3
7c6e12d
@Aitorbp
Added folder unreleased and calens
de89cb8
@Aitorbp
Calens changelog updated
bdf1fd8
@Aitorbp
Fixes from bitrise
2f70188
@dependabot @Aitorbp
Bump actions/checkout from 3 to 4
aa431e8 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@ownclouders @Aitorbp
[tx] updated from transifex
492883e
@ownclouders @Aitorbp
[tx] updated from transifex
3ee918b
@jesmrec @Aitorbp
new improvements in release checklist
4c2036e
@manuelplazaspalacio @Aitorbp
Added taskAffinity to application manifest.
8bc37ed
@jesmrec @Aitorbp
add new entry to release notes: http traffic banned
97f52cd
@Aitorbp
Avoiding crashes when it's null
dbbe403
@Aitorbp
Added calens
b2f94fd
@Aitorbp
Calens changelog updated
7834b11
@Aitorbp
Fix cr
91cfb0c
@Aitorbp
Calens changelog updated
df21ecd
@Aitorbp Aitorbp force-pushed the fix/npe_file_detail_fragment_google_play branch from fb12e3e to df21ecd Compare October 4, 2023 07:41
@JuancaG05 JuancaG05 changed the base branch from release/4.1.1 to master October 4, 2023 07:57
@JuancaG05 JuancaG05 closed this Oct 4, 2023
@JuancaG05
Copy link
Collaborator

PR with base release/4.1.1: #4178

@JuancaG05 JuancaG05 deleted the fix/npe_file_detail_fragment_google_play branch October 4, 2023 07:59
@JuancaG05 JuancaG05 mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees

@Aitorbp Aitorbp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPEs in FileDetailsFragment (Play Store)
8 participants
@Aitorbp @jesmrec @JuancaG05 @manuelplazaspalacio @ownclouders @parneet-guraya @abelgardep @michaelstingl